Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to torch 1.12.1 #1409

Merged
merged 2 commits into from
Aug 16, 2022
Merged

Conversation

abhi-mosaic
Copy link
Contributor

1.12.0 -> 1.12.1 comes with some bugfixes, particularly Adam optimizer resumption, that will be good to have.

@abhi-mosaic abhi-mosaic self-assigned this Aug 12, 2022
@abhi-mosaic abhi-mosaic requested review from bandish-shah and a team as code owners August 12, 2022 21:40
Copy link
Contributor

@bandish-shah bandish-shah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For all the PyTorch 1.12.1 updates I think we might need to update Torchvision to 0.13.1. Seems to be the case with the CPU image at least.

@abhi-mosaic
Copy link
Contributor Author

@bandish-shah I updated to torchvision 0.13.1 and all the checks seem to pass

Copy link
Contributor

@bandish-shah bandish-shah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@bandish-shah bandish-shah merged commit 06e7722 into mosaicml:dev Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants